-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor grouped queries in CgmesModel #3238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea68a93
to
860acf3
Compare
80d5838
to
d7f5aed
Compare
4e1fd3d
to
f680d6a
Compare
d7f5aed
to
b4c9a64
Compare
8561bd6
to
21a3627
Compare
f680d6a
to
f6b0c3e
Compare
21a3627
to
12aa957
Compare
zamarrenolm
reviewed
Jan 10, 2025
...n/java/com/powsybl/cgmes/conversion/elements/transformers/AbstractTransformerConversion.java
Outdated
Show resolved
Hide resolved
zamarrenolm
reviewed
Jan 10, 2025
...n/java/com/powsybl/cgmes/conversion/elements/transformers/AbstractTransformerConversion.java
Outdated
Show resolved
Hide resolved
5 tasks
Base automatically changed from
use_endnumber_for_powertransformerend_numbering
to
main
January 10, 2025 14:15
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
1f1cb2f
to
9f2f88f
Compare
olperr1
requested changes
Jan 14, 2025
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/hvdc/Adjacency.java
Show resolved
Hide resolved
olperr1
requested changes
Jan 15, 2025
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
olperr1
approved these changes
Jan 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Refactoring.
What is the current behavior?
There is a lack of consistency in the methods of CgmesModel that fetch data based on a common object ID. The methods don't have a similar naming, nor do they have a similar signature, and nor are they implemented in the same way and in the same class.
For instance:
What is the new behavior (if this is a feature change)?
Interface
CgmesModel
only provides full queries.Result from full queries is grouped by common object id and cached in
Context
.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Methods removed from
CgmesModel
:Map<String, PropertyBags> groupedTransformerEnds()
List<String> ratioTapChangerListForPowerTransformer(String powerTransformerId)
PropertyBags ratioTapChangerTable(String tableId)
List<String> phaseTapChangerListForPowerTransformer(String powerTransformerId)
PropertyBags phaseTapChangerTable(String tableId)
PropertyBags nonlinearShuntCompensatorPoints(String shuntId)
Have been replaced by these methodes in
Context
:public PropertyBags transformerEnds(String transformerId)
public PropertyBags ratioTapChangers(String transformerId)
public PropertyBags ratioTapChangerTablePoints(String tableId)
public PropertyBags phaseTapChangers(String transformerId)
public PropertyBags phaseTapChangerTablePoints(String tableId)
public PropertyBags nonlinearShuntCompensatorPoints(String shuntId)
Also, in
CgmesModel
, the following methods have been renamed for more consistency:ratioTapChangerTablesPoints()
intoratioTapChangerTablePoints()
phaseTapChangerTablesPoints()
intophaseTapChangerTablePoints()
Other information:
Early developments of separation of CGMES import (EQ separately from SSH) show the need for caching result of queries in the
Context
. This refactoring goes in the same direction.